Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON validation logic #47

Merged
merged 5 commits into from Nov 2, 2022
Merged

Update JSON validation logic #47

merged 5 commits into from Nov 2, 2022

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 1, 2022

Our JSON validation logic previously accepted undefined as valid JSON. undefined is not a valid JSON value however, so I've removed this. This also changes the JsonStruct and isValidJson function to use our custom JSON validation logic, removing the need for fast-deep-equal.

@Mrtenz Mrtenz requested a review from a team as a code owner November 1, 2022 15:28
@socket-security
Copy link

socket-security bot commented Nov 1, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Non-existent author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Powered by socket.dev

@rekmarks rekmarks changed the title Fix JSON validation logic Update JSON validation logic Nov 1, 2022
@Mrtenz Mrtenz merged commit 48feb84 into main Nov 2, 2022
@Mrtenz Mrtenz deleted the mrtenz/fix-json-validation branch November 2, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants