Add coercion utils #38
Conversation
|
I'm not sure we need those functions |
|
@ritave We need them for the upcoming |
| ); | ||
| }); | ||
|
|
||
| it.each([true, false, null, undefined, NaN, {}, []])( |
There was a problem hiding this comment.
console.log(createNumber(-0)); // -0
console.log(createNumber('-0')); // -0
console.log(createNumber(BigInt(-0))); // 0
There was a problem hiding this comment.
Do you think it is worth adding tests for these cases?
There was a problem hiding this comment.
it's literally 1 line change, why not.
But not that important if you want to just merge
| * This validates that the value is a number-like value, and that the resulting | ||
| * number is not `NaN` or `Infinity`. | ||
| * | ||
| * @example |
There was a problem hiding this comment.
Really loving the examples. We should do more of this in JSDocs.
|
After some thinking about it, and talking about it with some people, I decided to make the coercions more strict. Rather than guessing what the user meant, they only accept well defined values now. For example, the hex/byte coercions only accept hexadecimal strings, if they start with "0x" (or "0X"). This avoids situations like "should we parse |
| import { add0x } from './hex'; | ||
| import { bytesToHex, hexToBytes } from './bytes'; | ||
|
|
||
| describe('createNumber', () => { |
There was a problem hiding this comment.
Should we test that this accepts 0x-prefixed hex strings? And also treats strings that look like numbers as decimals?
There was a problem hiding this comment.
Lines 17 to 18 in d77e1c5
This adds utils for coercing values to a standardised value, e.g., a number or string to
bigint, or a hexadecimal string to a byte array, with some simple utility functions.