Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wallet_enable from examples #949

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Remove wallet_enable from examples #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe82c91
Remove wallet_enable from examples
FrederikBolding Nov 11, 2022
13b9908
Fix a test method
FrederikBolding Nov 11, 2022
f33bb54
Merge branch 'main' into fb/wallet-enable-examples
FrederikBolding Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/examples/examples/bls-signer/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,10 @@ <h1>BLS Signature Snap Example!</h1>

async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/browserify/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,10 @@ <h1>Hello, Snaps!</h1>
// here we get permissions to interact with and install the snap
async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/ethers-js/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,10 @@ <h1>Hello Snaps!</h1>

async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/insights/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,10 @@ <h1>Hello, Snaps!</h1>
// here we get permissions to interact with and install the snap
async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}
</script>
Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/ipfs/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,10 @@ <h1>Ipfs MetaMask Snap Example!</h1>

async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/notifications/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,10 @@ <h1>Hello, Snaps!</h1>
// here we get permissions to interact with and install the snap
async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/rollup/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,10 @@ sendNativeButton.addEventListener('click', () => send('native'));
*/
async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/typescript/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,10 @@ <h1>Hello, Snaps!</h1>
// here we get permissions to interact with and install the snap
async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/wasm/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,10 @@ <h1>WebAssembly Snap Example!</h1>

async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
10 changes: 4 additions & 6 deletions packages/examples/examples/webpack/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,10 @@ sendNativeButton.addEventListener('click', () => send('native'));
*/
async function connect() {
await ethereum.request({
method: 'wallet_enable',
params: [
{
wallet_snap: { [snapId]: {} },
},
],
method: 'wallet_requestSnaps',
params: {
[snapId]: {},
},
});
}

Expand Down
4 changes: 2 additions & 2 deletions packages/rpc-methods/src/permitted/requestSnaps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('implementation', () => {
const response = (await engine.handle({
jsonrpc: '2.0',
id: 1,
method: 'wallet_installSnaps',
method: 'wallet_requestSnaps',
params: {
[MOCK_SNAP_ID]: {},
},
Expand Down Expand Up @@ -122,7 +122,7 @@ describe('implementation', () => {
const response = (await engine.handle({
jsonrpc: '2.0',
id: 1,
method: 'wallet_installSnaps',
method: 'wallet_requestSnaps',
params: {
[MOCK_SNAP_ID]: {},
},
Expand Down