Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESM build issues #144

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix ESM build issues #144

wants to merge 1 commit into from

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 9, 2024

In #141 I tried to add an ESM build in a simple way, but this approach has several issues:

  • Running yarn build when the dist folder existed didn't work due to a TypeScript misconfiguration.
  • We had to rename *.js files to *.mjs, but source maps weren't renamed.
  • The module path was incorrect (but fixed by @wanseob in fix esm path on package.json #143).

In this PR I've copied the tsup config and related files instead, which should solve these issues.

Blocked by:

@Mrtenz Mrtenz requested a review from a team as a code owner March 9, 2024 09:53
Copy link

socket-security bot commented Mar 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/tsup@8.0.2 environment, eval, filesystem Transitive: network, shell, unsafe +147 336 MB egoist
npm/typescript@4.8.4 None 0 68.8 MB typescript-bot

🚮 Removed packages: npm/typescript@4.2.4

View full report↗︎

Copy link

socket-security bot commented Mar 9, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/anymatch@3.1.3
Shell access npm/commander@4.1.1
Shell access npm/mz@2.7.0
Network access npm/mz@2.7.0
Shell access npm/foreground-child@3.1.1
Shell access npm/foreground-child@3.1.1
Shell access npm/tree-kill@1.2.2
New author npm/source-map@0.8.0-beta.0
Shell access npm/esbuild@0.19.12
Install scripts npm/esbuild@0.19.12
Network access npm/esbuild@0.19.12
Network access npm/esbuild@0.19.12

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/anymatch@3.1.3
  • @SocketSecurity ignore npm/commander@4.1.1
  • @SocketSecurity ignore npm/mz@2.7.0
  • @SocketSecurity ignore npm/foreground-child@3.1.1
  • @SocketSecurity ignore npm/tree-kill@1.2.2
  • @SocketSecurity ignore npm/source-map@0.8.0-beta.0
  • @SocketSecurity ignore npm/esbuild@0.19.12

@Mrtenz Mrtenz marked this pull request as draft March 9, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant