Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for encryption methods #218

Merged
merged 1 commit into from Jul 26, 2022

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 19, 2022

A deprecation warning has been added for each of the two encryption-related methods. The deprecation warning has been implemented as middleware and included in both external providers (the inpage provider and the external extension provider).

@Gudahtt Gudahtt force-pushed the add-encryption-deprecation-warning branch from b7f24a3 to a94bd5a Compare July 19, 2022 15:29
@Gudahtt Gudahtt changed the base branch from main to improve-unit-tests July 19, 2022 15:29
@Gudahtt Gudahtt force-pushed the add-encryption-deprecation-warning branch from a94bd5a to 786f786 Compare July 19, 2022 15:30
@Gudahtt Gudahtt changed the title Add encryption deprecation warning Add deprecation warning for encryption methods Jul 19, 2022
@Gudahtt
Copy link
Member Author

Gudahtt commented Jul 19, 2022

This depends upon #219

@Gudahtt Gudahtt force-pushed the add-encryption-deprecation-warning branch from 786f786 to 19d7108 Compare July 19, 2022 15:43
@Gudahtt Gudahtt force-pushed the add-encryption-deprecation-warning branch from 19d7108 to e7d79a9 Compare July 19, 2022 15:52
Base automatically changed from improve-unit-tests to main July 26, 2022 21:37
@Gudahtt Gudahtt force-pushed the add-encryption-deprecation-warning branch from e7d79a9 to 19bc09f Compare July 26, 2022 21:37
A deprecation warning has been added for each of the two encryption-
related methods. The deprecation warning has been implemented as
middleware and included in both external providers (the inpage provider
and the external extension provider).
@Gudahtt Gudahtt force-pushed the add-encryption-deprecation-warning branch from 19bc09f to cd25a07 Compare July 26, 2022 21:44
@Gudahtt Gudahtt marked this pull request as ready for review July 26, 2022 21:46
@Gudahtt Gudahtt requested a review from a team as a code owner July 26, 2022 21:46
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@Gudahtt Gudahtt merged commit 139d427 into main Jul 26, 2022
@Gudahtt Gudahtt deleted the add-encryption-deprecation-warning branch July 26, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants