fix: @metamask/swaps-controller v9

[legobeat]

Description

• Upgrade @metamask/swaps-controller from v8 to v9

Resolves a bunch of outstanding legacy, including web-provider-engine.

Related issues

• revert: feat(swaps): enable Base for swaps (#9286) #9612
• feat(swaps): enable Base for swaps #9286

Blocked by

• https://github.com/MetaMask/swaps-controller/pull/232
  • https://github.com/MetaMask/swaps-controller/pull/219

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-json-rpc-middleware@12.1.0	network	+7	892 kB	metamaskbot
npm/@metamask/swappable-obj-proxy@2.2.0	None	0	36.9 kB	metamaskbot
npm/@metamask/swaps-controller@9.0.0-rc1	Transitive: environment, eval, filesystem, network	+75	45.1 MB	lgbot
npm/whatwg-fetch@3.6.20	network	0	57.4 kB	jakechampion

🚮 Removed packages: npm/@metamask/swappable-obj-proxy@2.1.0, npm/@metamask/swaps-controller@8.0.0, npm/whatwg-fetch@3.6.2

View full report↗︎

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
New author	npm/@metamask/swaps-controller@9.0.0-rc1	New Author: lgbot Previous Author: gudahtt	package.json
Unstable ownership	npm/@metamask/swaps-controller@9.0.0-rc1	Author: lgbot	package.json

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is unstable ownership?

A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

Try to reduce the amount of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/@metamask/swaps-controller@9.0.0-rc1

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2adf95f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ebcc7bec-2a7b-4f03-87fb-50de0a90d192

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud