Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type renderHookWithProvider #9578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: type renderHookWithProvider #9578

wants to merge 2 commits into from
+5 −5

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented May 9, 2024

Description

This PR adds the correct typing to our test helper renderHookWithProvider, preserving the types from the wrapped renderHook.

Related issues

Fixes: N/A

Manual testing steps

N/A

Screenshots/Recordings

Before After
before_app:components:UI:Ramp:hooks:useActivationKeys test ts after_app:components:UI:Ramp:hooks:useActivationKeys test ts
before_app:components:UI:Ramp:hooks:useGasPriceEstimation test ts after_app:components:UI:Ramp:hooks:useGasPriceEstimation test ts
before_app:components:hooks:useBlockExplorer test ts after_app:components:hooks:useBlockExplorer test ts

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited by metamaskbot

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b5b39fe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8216e721-620c-45d4-a99d-76b2fd0ee85d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei marked this pull request as ready for review May 9, 2024 00:36
@wachunei wachunei requested a review from a team as a code owner May 9, 2024 00:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wachunei