Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update confirmations codeowners #9574

Merged
merged 1 commit into from May 23, 2024
Merged

chore: update confirmations codeowners #9574

merged 1 commit into from May 23, 2024
+2 −2

Conversation

cryptotavares
Copy link
Contributor

Description

Updates the codeowners file to reference the new Confirmations team.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptotavares cryptotavares requested a review from a team as a code owner May 8, 2024 08:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label May 8, 2024
sethkfman
sethkfman previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptotavares
chore: update confirmations codeowners
c0d7782 
With the two teams merging, we are
updating the github team as well.
@cryptotavares cryptotavares force-pushed the chore/update-confirmations-codeowner branch from 09dbf85 to c0d7782 Compare May 20, 2024 17:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sethkfman
sethkfman approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryptotavares cryptotavares merged commit f6505db into main May 23, 2024
31 checks passed
@cryptotavares cryptotavares deleted the chore/update-confirmations-codeowner branch May 23, 2024 13:09
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@sethkfman sethkfman sethkfman approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees
No one assigned
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cryptotavares @OGPoyraz @sethkfman @pedronfigueiredo @metamaskbot