fix: 9559 issue android json parse

[Jonathansoufer]

Description

Fix issue on Android while handling notifications (JSON parse)

Related issues

Fixes: 9559

Manual testing steps

1. Enable notifications feature (feature flag)
2. Submit any transaction within the app

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2e67dfb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb0f5cef-ce58-4d6b-bf32-ce88df6dc7d1

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 20.00000% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 46.78%. Comparing base (678c2f6) to head (b8c7c7a).
Report is 5 commits behind head on main.

Files	Patch %	Lines
app/util/notifications/hooks/index.ts	26.31%	14 Missing ⚠️
app/components/Nav/Main/index.js	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9568      +/-   ##
==========================================
+ Coverage   46.66%   46.78%   +0.12%     
==========================================
  Files        1343     1344       +1     
  Lines       32805    32803       -2     
  Branches     3527     3525       -2     
==========================================
+ Hits        15307    15347      +40     
+ Misses      16554    16511      -43     
- Partials      944      945       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d57cff4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/26355779-bd92-4bca-811e-0404f2e09202

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

Quality Gate failed

Failed conditions 23.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

Let's increase test coverage for the notifications hook. That should be able to clear the threshold.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f22f949
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/81339d1e-90f7-442f-a5e1-f13f655de3df

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[NicolasMassart]

hi @Jonathansoufer, could you fix this PR description and an explicit unit test to prove that #9559 is fixed by this PR please?
I would expect a unit test that uses a mock JSON similar to the one that made the app fail before to make sure we can consider this PR as a fix for the parsing issue. Thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
21.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sethkfman]

LGTM