Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/smart tx 3 – DO NOT REVIEW #9567

Draft
wants to merge 171 commits into
base: main
Choose a base branch
from
Draft

Feat/smart tx 3 – DO NOT REVIEW #9567

wants to merge 171 commits into from
+9,656 −731

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented May 7, 2024 •
edited by dbrans

DO NOT REVIEW

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vinistevam and others added 30 commits May 2, 2024 15:35
@vinistevam @infiniteflower
Implement STX
887015f
@infiniteflower
Apply v8 tx controller patch
1d83ea4
@infiniteflower
Revert change to whatsnew modal
6b22f82
@infiniteflower
Revert changes to whats new modal
80ae527
@infiniteflower
Remove testnet stuff for swaps
64b171c
@infiniteflower
Remove more testnet stuff for swaps
11fd5f6
@infiniteflower
Remove unused code
2e86b11
@infiniteflower
Revert "Remove more testnet stuff for swaps"
1bf517e 
This reverts commit 5bfe24e.
@infiniteflower
Fix feature flags on testnet
2ad6b97
@infiniteflower
Fix engine stx analytics
6b0dcac
@infiniteflower
Improve typing
c164a42
@infiniteflower
Use TransactionType from Tx Controller
aa01d1f
@infiniteflower
refactor comments
5df5dee
@infiniteflower
Remove whats new thats different from main
f269f0a
@infiniteflower
Add stx controller to initial bg state in tests
c6fa108
@infiniteflower
Move stx enabled selectors to own file
b05e6d5
@infiniteflower
Add tests for swap reducer/selector
df413ae
@infiniteflower
Refactor test setup to be simpler
8369939
@infiniteflower
Ignore ts error
35b393a
@infiniteflower
Get STX controller test skeleton working
3c794ee
@infiniteflower
Hide the default template buttons on stx status page
d8b1a80
@infiniteflower
Fix transaction vs txParams field incompatibilty between txController…
778e393 
… v8 and STX controller

(patch will be added in separate commit)
@infiniteflower
Apply new tx controller patch
f9645ac
@infiniteflower
Revert changes to pref controller patch
efb72a2
@infiniteflower
Update preferences controller patch for stx
b8a70e0
@infiniteflower
Add tests for getSmartTransactionsEnabled
4420551
@infiniteflower
Remove logs
bed7cc5
@infiniteflower
Add another test for getSmartTransactionsEnabled
9e36e44
@infiniteflower
Refactor test helper function
bd7f300
@infiniteflower
Add tests for getIsSmartTransaction
304115a
@infiniteflower
fix: add default value for env var MM_FOX_CODE to fix smart-tx tests
64a28fb
@infiniteflower
chore: use existing Security icon and remove the new one
e3e3e89
@infiniteflower
chore: bump build numbers
55c8000
@infiniteflower
chore: bump version and build numbers
661611b
@infiniteflower
fix: dark mode STX status screen header wrong color
3597b50
@infiniteflower
fix: do not show whats new after STX opt in, too many modals
90671b5
@infiniteflower
chore: remove dev logs
3cd4b34
@infiniteflower
chore: remove more dev logs
56a73cb
@infiniteflower
chore: remove even more dev logs
bf8ed68
@infiniteflower
chore: remove unused lib
ca8611d
@infiniteflower
chore: bump podfile and pbxproj
5d93767
@infiniteflower
fix: eslint issues
80b0a18
@infiniteflower
fix: ts lint error
2646df6
@infiniteflower
chore: remove unused code
ac50d54
@infiniteflower
fix: lint errors
9f826e1
@infiniteflower
chore: remove unused import
a859d13
@infiniteflower
chore: Update dependencies in yarn.lock
c7d32cd
@infiniteflower
chore: remove unused code
9bc57e2
@infiniteflower
fix: broken tests
e36c5e4
@infiniteflower
fix: broken tests
bf06be8
@infiniteflower
fix: broken tests
45948c4
@infiniteflower
chore: update yarn lock
ee20fd8
@infiniteflower
chore: update yarn lock
e3c4f3e
@infiniteflower
chore: remove yalc stuff from gitignore
c54db29
@infiniteflower
Revert "chore: remove yalc stuff from gitignore"
11dd5ba 
This reverts commit d2d26a3.
@infiniteflower
Revert "Revert "chore: remove yalc stuff from gitignore""
c00982c 
This reverts commit d405ed2.
@infiniteflower
chore: update yarn.lock
ad4b748
@infiniteflower
chore: update yarn.lock
f8fadcd
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans changed the title Feat/smart tx 3 Feat/smart tx 3 – DO NOT REVIEW May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infiniteflower @vinistevam