fix: Yarn 1.22.22 #9143

leotm · 2024-04-04T18:10:29Z

Description

Prevent engineers using different Yarn versions with different features
causing our CI dedupe step to break

Bump package.json Yarn engine from ^1.22.0 to 1.22.22
Bump BitRise Yarn version from 1.22.19 to 1.22.22
Lock project Yarn version to 1.22.22
Add Yarn config file comment RE @lavamoat/allow-scripts setup
Run yarn deduplicate and commit
Revert Bump BitRise Yarn version from 1.22.19 to 1.22.22 (thread)
Bump BitRise Yarn version from 1.22.19 to 1.22.22
- Fix missing ASC file for 1.20.22, 1.20.20, 1.20.21 yarnpkg/yarn#9050
- Switch to ~~NPM or~~ Corepack

Nb: our metamask-extension setup

https://classic.yarnpkg.com/lang/en/docs/package-json/#toc-engines

The engines specify versions of clients that must be used with your package. This checks against process.versions as well as the current version of yarn.

https://classic.yarnpkg.com/lang/en/docs/yarnrc/#toc-yarn-path

Instructs yarn to defer to another Yarn binary for execution. Useful if you want to bundle Yarn into your repository and have everyone use the same version for consistency. This was introduced in Yarn 1.0, so all developers must have Yarn >= 1.0 installed.

https://yarnpkg.com/getting-started/qa

.yarn/plugins and .yarn/releases contain the Yarn releases used in the current repository (as defined by yarn set version). You will want to keep them versioned (this prevents potential issues if, say, two engineers use different Yarn versions with different features).

https://yarnpkg.com/cli/set/version

Lock the Yarn version used by the project.

https://nodejs.org/dist/latest-v15.x/docs/api/all.html (introduced in Node v16 only)
https://nodejs.org/dist/latest-v16.x/docs/api/all.html#all_packages_packagemanager
from testing our repo (on Node v18), this appears to have no effect enforcing the version

from testing our repo, we could revert c7d67e6 to keep our structure simpler
since the package.json engine field is enough to enforce the version
but these 2 files are generated by running yarn set version 1.22.22

Yarn v1.22 update

PR: Fixes the lockfile hydration of the npm: protocol yarnpkg/yarn#9023
Commit: yarnpkg/yarn@88d5e44
Picked into branch: https://github.com/yarnpkg/yarn/tree/1.22-stable

Related issues

Fixes: CI dedupe step consistently failing

Manual testing steps

ensure yarn --version is below 1.22.22
or e.g. yarn set version 1.22.21
run yarn
Yarn errors correctly ^1.22.22+ is expected

Nb: after doing this too many times, you can use a VPN as a workaround

Screenshots/Recordings

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Docs: https://classic.yarnpkg.com/lang/en/docs/package-json/#toc-engines Contains lockfile hydration fix - PR: yarnpkg/yarn#9023 - Commit: yarnpkg/yarn@88d5e44

Autogenerated by Yarn CLI Docs: https://yarnpkg.com/cli/set/version Like we currently lock metamask-extension to v4.0.2

github-actions · 2024-04-04T18:10:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

.yarnrc

package.json

Resolve: https://github.com/MetaMask/metamask-mobile/pull/9143/files#r1552207338

NicolasMassart

Thanks for this! Will improve contribution onboarding too!

codecov-commenter · 2024-04-04T18:52:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.79%. Comparing base (f7466da) to head (3f3a1f5).
Report is 63 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9143      +/-   ##
==========================================
+ Coverage   45.58%   45.79%   +0.21%     
==========================================
  Files        1289     1317      +28     
  Lines       31973    32325     +352     
  Branches     3314     3368      +54     
==========================================
+ Hits        14574    14804     +230     
- Misses      16528    16632     +104     
- Partials      871      889      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bitrise.yml

leotm · 2024-04-04T19:13:13Z

Ref

Bump minimum yarn version suggested in package.json engines #9144

This reverts commit 4deff12.

github-actions · 2024-04-22T19:00:16Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fb17b39
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/255bc30d-934a-4a44-879a-e65e8855e9e1

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

bitrise.yml

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

github-actions · 2024-04-24T17:33:10Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 75828e7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/756b8071-69cb-48bb-b0a8-272eea4dc95c

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-04-24T20:43:35Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3f3a1f5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a75ec664-86e1-4cbe-aaa1-083ab390dadd

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-04-25T06:51:32Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 182526d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf882365-6ecb-4ccd-8b48-169946fd4106

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-04-30T10:24:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sethkfman

LGTM

leotm added 4 commits April 4, 2024 19:02

Bump package.json Yarn engine from ^1.22.0 to 1.22.22

0b36b11

Docs: https://classic.yarnpkg.com/lang/en/docs/package-json/#toc-engines Contains lockfile hydration fix - PR: yarnpkg/yarn#9023 - Commit: yarnpkg/yarn@88d5e44

Format

79af110

Bump BitRise Yarn version from 1.22.19 to 1.22.22

4deff12

Lock project Yarn version to 1.22.22

c7d67e6

Autogenerated by Yarn CLI Docs: https://yarnpkg.com/cli/set/version Like we currently lock metamask-extension to v4.0.2

leotm requested review from Gudahtt and Cal-L April 4, 2024 18:10

leotm commented Apr 4, 2024

View reviewed changes

.yarnrc Outdated Show resolved Hide resolved

leotm commented Apr 4, 2024

View reviewed changes

package.json Show resolved Hide resolved

leotm changed the title ~~Yarn 1.22.22~~ chore: Yarn 1.22.22 Apr 4, 2024

leotm changed the title ~~chore: Yarn 1.22.22~~ fix: Yarn 1.22.22 Apr 4, 2024

Add Yarn config file comment

2ce766d

Resolve: https://github.com/MetaMask/metamask-mobile/pull/9143/files#r1552207338

leotm added team-mobile-platform team-lavamoat labels Apr 4, 2024

leotm marked this pull request as ready for review April 4, 2024 18:33

leotm requested review from a team as code owners April 4, 2024 18:33

leotm marked this pull request as draft April 4, 2024 18:36

Deduplicate deps with Yarn

e5017fb

leotm marked this pull request as ready for review April 4, 2024 18:39

NicolasMassart previously approved these changes Apr 4, 2024

View reviewed changes

leotm requested review from NicholasEllul and tommasini April 4, 2024 19:09

leotm commented Apr 4, 2024

View reviewed changes

bitrise.yml Show resolved Hide resolved

leotm added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 4, 2024

This comment was marked as resolved.

Sign in to view

Revert "Bump BitRise Yarn version from 1.22.19 to 1.22.22"

285fadd

This reverts commit 4deff12.

leotm dismissed NicolasMassart’s stale review via 285fadd April 4, 2024 19:40

leotm added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 22, 2024

legobeat reviewed Apr 22, 2024

View reviewed changes

bitrise.yml Outdated Show resolved Hide resolved

leotm requested a review from legobeat April 23, 2024 21:29

leotm marked this pull request as ready for review April 23, 2024 21:29

Favour Corepack over NPM

75828e7

Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>

leotm added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 24, 2024

Merge branch 'main' into yarn-1.22.22

3f3a1f5

legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 24, 2024

Merge branch 'main' into yarn-1.22.22

182526d

leotm removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 25, 2024

legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 25, 2024

legobeat approved these changes Apr 25, 2024

View reviewed changes

legobeat requested a review from a team April 25, 2024 07:15

legobeat mentioned this pull request Apr 30, 2024

fix: update bitrise yarn version from 12.22.19 to 1.22.22 #9451

Closed

7 tasks

Merge branch 'main' into yarn-1.22.22

3464002

legobeat approved these changes Apr 30, 2024

View reviewed changes

Merge branch 'main' into yarn-1.22.22

84aa83a

legobeat requested a review from a team April 30, 2024 10:33

sethkfman approved these changes Apr 30, 2024

View reviewed changes

leotm merged commit 93dc225 into main Apr 30, 2024
39 checks passed

leotm deleted the yarn-1.22.22 branch April 30, 2024 14:56

github-actions bot locked and limited conversation to collaborators Apr 30, 2024

metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Yarn 1.22.22 #9143

fix: Yarn 1.22.22 #9143

leotm commented Apr 4, 2024 •

edited

github-actions bot commented Apr 4, 2024

NicolasMassart left a comment

codecov-commenter commented Apr 4, 2024 •

edited

leotm commented Apr 4, 2024

This comment was marked as resolved.

github-actions bot commented Apr 22, 2024 •

edited by metamaskbot

github-actions bot commented Apr 24, 2024 •

edited by metamaskbot

github-actions bot commented Apr 24, 2024

github-actions bot commented Apr 25, 2024 •

edited by metamaskbot

sonarcloud bot commented Apr 30, 2024

sethkfman left a comment

fix: Yarn 1.22.22 #9143

fix: Yarn 1.22.22 #9143

Conversation

leotm commented Apr 4, 2024 • edited

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 4, 2024

NicolasMassart left a comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 4, 2024 • edited

Codecov Report

leotm commented Apr 4, 2024

This comment was marked as resolved.

github-actions bot commented Apr 22, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Apr 24, 2024 • edited by metamaskbot

Bitrise

github-actions bot commented Apr 24, 2024

Bitrise

github-actions bot commented Apr 25, 2024 • edited by metamaskbot

Bitrise

sonarcloud bot commented Apr 30, 2024

Quality Gate passed

sethkfman left a comment

Choose a reason for hiding this comment

leotm commented Apr 4, 2024 •

edited

codecov-commenter commented Apr 4, 2024 •

edited

github-actions bot commented Apr 22, 2024 •

edited by metamaskbot

github-actions bot commented Apr 24, 2024 •

edited by metamaskbot

github-actions bot commented Apr 25, 2024 •

edited by metamaskbot