Migrate to new controller packages #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
mcmire
commented
Nov 18, 2022
|
Marking as |
|
I have added the token as |
|
I'm going to keep this PR in draft mode so that if we need to make updates we can continue to access the preview versions of the aforementioned packages via the GitHub Package Registry, but feel free to leave your comments on this PR. |
mcmire
commented
Nov 18, 2022
mcmire
added
needs-dev-review
Gudahtt
reviewed
Nov 21, 2022
Gudahtt
force-pushed
the
migrate-to-new-controller-packages
branch
from
d874a30
to
a53a1e4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
migrate-to-new-controller-packages
branch
from
f565e97
to
39f804e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
migrate-to-new-controller-packages
branch
from
39f804e
to
bb172c3
Compare
Gudahtt
force-pushed
the
migrate-to-new-controller-packages
branch
from
bb172c3
to
faa0eee
Compare
Gudahtt
reviewed
Dec 14, 2022
Gudahtt
force-pushed
the
migrate-to-new-controller-packages
branch
3 times, most recently
from
668be34
to
e1675d1
Compare
Gudahtt
force-pushed
the
migrate-to-new-controller-packages
branch
from
e1675d1
to
4cb3033
Compare
`@metamask/controllers` is deprecated, and most of the controllers that lived here are now located in their own package ([1]). This commit replaces `@metamask/controllers` in `package.json` with references to these packages and updates `import` lines to match. [1]: MetaMask/core#831
CI now supports fetching packages from the GitHub Packages registry on draft PRs. This is meant to support the use of "preview" builds of controller packages, to more easily test controller changes before they are released.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
force-pushed
the
migrate-to-new-controller-packages
branch
from
4cb3033
to
1e59d83
Compare
gantunesr
approved these changes
Jan 10, 2023
gantunesr
removed
the
needs-dev-review
…ller-packages * origin/main: [IMPROVEMENT] Remove deeplink warning for SDK and SDK as dependency (#5449) On-Ramp: Settings and Activation Keys (#5455) [FIX] Screenshot deterrent analytics (#5468) On-ramp: Remove unused constants (#5462) On-ramp: Refactor Regions view to componentization (#5413) Approval error when insufficient balance (#5440) remove extra zero balance account potentially created from seeking ahead (#5459) [IMPROVEMENT] Refactor Analytics Events (#5454)
Gudahtt
added
the
needs-qa
chrisleewilcox
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
@metamask/controllersis deprecated, and most of the controllers that lived here are now located in their own package. This commit replaces@metamask/controllersinpackage.jsonwith references to these packages and updatesimportlines to match.Issue
Testing notes
This is a behind-the-scenes change, and there should be no changes to existing functionality — everything should work as it does currently. I'm not sure what the best protocol to test these sorts of changes is (maybe run through the most common scenarios?)
Custom registry setup (skip these steps, these were only relevant before we published these packages)
Note that before this PR gets merged, preview versions of the new packages, which live on GitHub Packages, will be used. Without specially configuring NPM, these packages will not be accessible locally, and therefore you will not be able to run
yarn setup. To get this working:.npmrcin the root directory with the following content (note: this file is gitignored, so don't worry about it ending up in the repo):Now you should be able to run
yarn setup, then load the app as you normally would.Checklist