-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade react-redux to support react 18; bump redux packages #9618
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@reduxjs/toolkit@1.9.5, npm/minipass@7.0.4, npm/react-redux@7.2.4, npm/redux-persist-filesystem-storage@3.0.0, npm/redux-saga@1.2.3, npm/redux@4.1.1, npm/rn-fetch-blob@0.12.0 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
d058ac9
to
d573178
Compare
This comment was marked as resolved.
This comment was marked as resolved.
8645eac
to
61422cd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Bitrise✅✅✅ Commit hash: 61422cd Note
|
4795b5a
to
25f55d7
Compare
Bitrise✅✅✅ Commit hash: 25f55d7 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9618 +/- ##
==========================================
+ Coverage 46.27% 46.42% +0.14%
==========================================
Files 1336 1340 +4
Lines 32582 32574 -8
Branches 3445 3483 +38
==========================================
+ Hits 15076 15121 +45
+ Misses 16594 16520 -74
- Partials 912 933 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Bitrise✅✅✅ Commit hash: 09ec49b Note
|
Currenlty used React version 18 is not officially supported until react-redux v8. Also brings in updates for other redux packages, but holds off on breaking changes for @reduxjs/toolkit v2.
The latter is a maintained fork of abandoned former. Holding on 0.18 to dedupliate on already used version from redux-perists-filesystem-storage. robwalkerco/redux-persist-filesystem-storage#68
- chore: dedupe react-native-blob-util thru resolutions
Resolved conflict in |
Quality Gate passedIssues Measures |
Bitrise🔄🔄🔄 Commit hash: c39099b Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Currently used React version 18 is not officially supported until react-redux v8. Also brings in updates for other redux packages, but holds off on breaking changes for @reduxjs/toolkit v2.
react-redux
from4.1.1
to4.2.1
4.2.1
was already used transitively so this is effectively a dedupern-fetch-blob
withreact-native-blob-util
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist