Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry] SyntaxError: JSON Parse error: Unexpected token: o #9559

Closed
sentry-io bot opened this issue May 6, 2024 · 2 comments · Fixed by #9568
Closed

[Sentry] SyntaxError: JSON Parse error: Unexpected token: o #9559

sentry-io bot opened this issue May 6, 2024 · 2 comments · Fixed by #9568
Labels
area-Sentry Issue from Sentry regression-prod-7.21.0 Regression bug that was found in production in release 7.21.0 release-7.24.0 Issue or pull request that will be included in release 7.24.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-notifications Notifications team type-bug Something isn't working

Comments

@sentry-io
Copy link

sentry-io bot commented May 6, 2024

Sentry Issue: METAMASK-MOBILE-2CVF

SyntaxError: JSON Parse error: Unexpected token: o
  at emit (app:///index.android.bundle:22:16)
  at emit (app:///index.android.bundle:22:16)
...
(8 additional frame(s) were not displayed)
@sethkfman sethkfman added team-mobile-platform type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-notifications Notifications team and removed team-mobile-platform labels May 6, 2024
@metamaskbot metamaskbot changed the title SyntaxError: JSON Parse error: Unexpected token: o [Sentry] SyntaxError: JSON Parse error: Unexpected token: o May 8, 2024
@metamaskbot metamaskbot added area-Sentry Issue from Sentry regression-prod-7.21.0 Regression bug that was found in production in release 7.21.0 labels May 8, 2024
Copy link
Author

sentry-io bot commented May 16, 2024

Sentry Issue: METAMASK-MOBILE-2CX7

Copy link
Author

sentry-io bot commented May 21, 2024

Sentry Issue: METAMASK-MOBILE-294G

sethkfman added a commit that referenced this issue May 21, 2024
## **Description**

Fix issue on Android while handling notifications (JSON parse)

## **Related issues**

Fixes: [9559](#9559)

## **Manual testing steps**

1. Enable notifications feature (feature flag)
2. Submit any transaction within the app
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: sethkfman <seth.kaufman@consensys.net>
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 21, 2024
Jonathansoufer added a commit that referenced this issue May 22, 2024
## **Description**

This is a cherry picking of commit
6c5f55c from PR #9568

## **Related issues**

Fixes: #9559

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry Issue from Sentry regression-prod-7.21.0 Regression bug that was found in production in release 7.21.0 release-7.24.0 Issue or pull request that will be included in release 7.24.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-notifications Notifications team type-bug Something isn't working
Projects
Archived in project
Status: Fixed
Development

Successfully merging a pull request may close this issue.

2 participants