-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 9559 issue android json parse #9568
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 2e67dfb Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9568 +/- ##
==========================================
+ Coverage 46.66% 46.78% +0.12%
==========================================
Files 1343 1344 +1
Lines 32805 32803 -2
Branches 3527 3525 -2
==========================================
+ Hits 15307 15347 +40
+ Misses 16554 16511 -43
- Partials 944 945 +1 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: d57cff4 Note
|
Let's increase test coverage for the notifications hook. That should be able to clear the threshold. |
Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
Bitrise✅✅✅ Commit hash: f22f949 Note
|
hi @Jonathansoufer, could you fix this PR description and an explicit unit test to prove that #9559 is fixed by this PR please? |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fix issue on Android while handling notifications (JSON parse)
Related issues
Fixes: 9559
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist