Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: squirrelly 9 #19113

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 13, 2023

Explanation

CVE-2021-32819 / GHSA-q8j6-pwqx-pm96

Change (guess who 😉): squirrellyjs/squirrelly#254

v9 release notes: https://github.com/squirrellyjs/squirrelly/releases/tag/v9.0.0

Testing instructions

$ yarn dist
$ yarn start

TODO:

  • port custom patch

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added type-security dependencies Pull requests that update a dependency file labels May 13, 2023
@socket-security
Copy link

socket-security bot commented May 13, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
CVE ✅ 0 issues
Mild CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Filesystem access ✅ 0 issues
Network access ✅ 0 issues
Shell access ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
No bug tracker ✅ 0 issues
No contributors or author data ✅ 0 issues
No README ✅ 0 issues
Deprecated ✅ 0 issues
New author ✅ 0 issues
Unstable ownership ✅ 0 issues
Non-existent author ✅ 0 issues
Unmaintained ✅ 0 issues
Unpublished package ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
squirrelly@9.0.0 8.0.8...9.0.0 None +0/-0 nebrelbug

@legobeat legobeat force-pushed the devDeps-squirrelly-9 branch 2 times, most recently from 96357c2 to 517ad20 Compare May 13, 2023 02:44
@legobeat legobeat marked this pull request as ready for review May 13, 2023 02:54
@legobeat legobeat requested a review from a team as a code owner May 13, 2023 02:54
@legobeat legobeat requested a review from chloeYue May 13, 2023 02:54
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #19113 (47b4932) into develop (49f8052) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 47b4932 differs from pull request most recent head d86d9bb. Consider uploading reports for the commit d86d9bb to get more accurate results

@@             Coverage Diff             @@
##           develop   #19113      +/-   ##
===========================================
- Coverage    70.09%   70.08%   -0.01%     
===========================================
  Files          963      963              
  Lines        37222    37222              
  Branches      9622     9622              
===========================================
- Hits         26089    26087       -2     
- Misses       11133    11135       +2     

see 2 files with indirect coverage changes

@legobeat legobeat requested a review from kumavis May 15, 2023 06:23
@legobeat legobeat force-pushed the devDeps-squirrelly-9 branch 4 times, most recently from dad444a to 2463a34 Compare May 17, 2023 13:17
brad-decker
brad-decker previously approved these changes May 17, 2023
@legobeat legobeat force-pushed the devDeps-squirrelly-9 branch 3 times, most recently from afbaf35 to bd2615e Compare May 17, 2023 21:24
kumavis
kumavis previously approved these changes May 18, 2023
@legobeat
Copy link
Contributor Author

legobeat commented May 18, 2023

@kumavis ci e2e timeout errors look unrelated but merging is blockeddue to not all checks passing. Should I do a no-diff force-push to retrigger the flakey test?

EDIT: Had to do it anyway due to merge-conflict. Nothing should be changed here from last review round.

@legobeat legobeat requested a review from a team May 18, 2023 13:44
@legobeat legobeat added the area-buildSystem related to our build system label May 20, 2023
@legobeat legobeat merged commit dc580c1 into MetaMask:develop May 31, 2023
47 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-buildSystem related to our build system dependencies Pull requests that update a dependency file type-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants