Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fox mesh JSON warning #12200

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Prevent fox mesh JSON warning #12200

merged 3 commits into from
Sep 27, 2021

Conversation

darkwing
Copy link
Contributor

Explanation: The fox mesh was displaying a console warning because its value was correctly undefined but the presence check wasn't properly coded to allow an undefined value.

@darkwing darkwing requested a review from a team as a code owner September 23, 2021 20:15
@darkwing darkwing requested a review from danjm September 23, 2021 20:15
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2147076]
Page Load Metrics (272 ± 20 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint503312267034
domContentLoaded2324212574421
load2474302724220
domInteractive2324212574421

highlights:

storybook

ryanml
ryanml previously approved these changes Sep 23, 2021
Gudahtt
Gudahtt previously approved these changes Sep 24, 2021
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@darkwing darkwing dismissed stale reviews from Gudahtt and ryanml via 477c162 September 27, 2021 16:30
Gudahtt
Gudahtt previously approved these changes Sep 27, 2021
@kumavis
Copy link
Member

kumavis commented Sep 27, 2021

e2e failure looks unrelated

@kumavis kumavis merged commit 2e2bd0f into develop Sep 27, 2021
@kumavis kumavis deleted the avoid-build-errorr branch September 27, 2021 22:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2021
@kumavis
Copy link
Member

kumavis commented Sep 27, 2021

merged via admin access

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants