Add CommonJS ESLint configuration #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new package has been added for CommonJS projects. Primarily this configuration will allow CommonJS globals such as `require`. The environment config generation script was updated to support this new package. This required changes to allow combining both `shared-node-browser` and `commonjs` globals in the same configuration.
Gudahtt
force-pushed
the
add-commonjs-config
branch
from
bea23a1
to
ab4fe5b
Compare
Mrtenz
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new package has been added for CommonJS projects. Primarily this configuration will allow CommonJS globals such as
require.The environment config generation script was updated to support this new package. This required changes to allow combining both
shared-node-browserandcommonjsglobals in the same configuration.