Automatically sort imports #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Nov 11, 2022
| { | ||
| // This means that there will always be a newline between the import | ||
| // groups as defined below. | ||
| 'newlines-between': 'always', |
There was a problem hiding this comment.
I think personally this makes it easier to distinguish external imports from internal ones. I'm open to change this however.
ritave
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some configuration to the
import/orderrule, to make sure we automatically sort imports (fixable witheslint --fix). Imports will be sorted in two groups:node_modules).Within these groups, imports are sorted alphabetically. A new line is placed between each import group, and the actual code.