Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement arrow-body-style to remove unnecessary return statements #205

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement arrow-body-style to remove unnecessary return statements #205

wants to merge 1 commit into from

Conversation

darkwing
Copy link
Contributor

As voted positively here: MetaMask/metamask-extension#12127

@darkwing darkwing requested a review from a team as a code owner September 16, 2021 18:18
@darkwing darkwing mentioned this pull request Sep 16, 2021
Closed
@Gudahtt
Copy link
Member

Gudahtt commented Sep 16, 2021

You'll need to run yarn lint:config-validation -w to update the rule snapshots.

We should document this in the README 🤔

@Gudahtt
Copy link
Member

Gudahtt commented Sep 16, 2021

Apparently this rule conflicts with prettier 😞
prettier/eslint-plugin-prettier#65

@rekmarks rekmarks marked this pull request as draft September 22, 2021 00:07
@rekmarks
Copy link
Member

@darkwing I converted this to a draft since it conflicts with Prettier :<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darkwing @Gudahtt @rekmarks