Enable id-denylist and id-length in base config

MetaMask · Aug 19, 2021 · d75f63a · d75f63a
1 parent 167d4f1
commit d75f63a
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/packages/base/rules-snapshot.json b/packages/base/rules-snapshot.json
@@ -83,6 +83,26 @@
   "getter-return": "error",
   "grouped-accessor-pairs": "error",
   "guard-for-in": "error",
+  "id-denylist": [
+    "error",
+    "err",
+    "cb",
+    "callback",
+    "req",
+    "res"
+  ],
+  "id-length": [
+    "error",
+    {
+      "min": 2,
+      "properties": "never",
+      "exceptions": [
+        "i",
+        "j",
+        "k"
+      ]
+    }
+  ],
   "implicit-arrow-linebreak": "off",
   "import/default": "error",
   "import/export": "error",

diff --git a/packages/base/src/index.js b/packages/base/src/index.js
@@ -71,6 +71,18 @@ module.exports = {
     'func-name-matching': 'error',
     'grouped-accessor-pairs': 'error',
     'guard-for-in': 'error',
+    'id-denylist': [
+      'error', // this sets this rule to error, the rest are the forbidden IDs
+      'err',
+      'cb',
+      'callback',
+      'req',
+      'res',
+    ],
+    'id-length': [
+      'error',
+      { min: 2, properties: 'never', exceptionPatterns: ['[i-k]', '[x-z]'] },
+    ],
     'lines-between-class-members': 'error',
     'max-statements-per-line': [
       'error',