Allow 'a' and 'b' as identifiers

MetaMask · Aug 15, 2022 · 946ccc3 · 946ccc3
1 parent 4d70dbb
commit 946ccc3
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/packages/base/rules-snapshot.json b/packages/base/rules-snapshot.json
@@ -91,7 +91,7 @@
     {
       "min": 2,
       "properties": "never",
-      "exceptionPatterns": ["_", "i", "j", "k"]
+      "exceptionPatterns": ["_", "a", "b", "i", "j", "k"]
     }
   ],
   "implicit-arrow-linebreak": "off",

diff --git a/packages/base/src/index.js b/packages/base/src/index.js
@@ -92,7 +92,7 @@ module.exports = {
       {
         min: 2,
         properties: 'never',
-        exceptionPatterns: ['_', 'i', 'j', 'k'],
+        exceptionPatterns: ['_', 'a', 'b', 'i', 'j', 'k'],
       },
     ],
     'lines-between-class-members': 'error',

diff --git a/packages/jest/rules-snapshot.json b/packages/jest/rules-snapshot.json
@@ -40,18 +40,16 @@
   "jest/no-standalone-expect": "error",
   "jest/no-test-prefixes": "error",
   "jest/no-test-return-statement": "error",
-  "jest/no-try-expect": "error",
   "jest/prefer-hooks-on-top": "error",
   "jest/prefer-spy-on": "error",
   "jest/prefer-strict-equal": "error",
-  "jest/prefer-to-be-null": "error",
-  "jest/prefer-to-be-undefined": "error",
+  "jest/prefer-to-be": "error",
   "jest/prefer-to-contain": "error",
   "jest/prefer-to-have-length": "error",
   "jest/prefer-todo": "error",
   "jest/require-to-throw-message": "error",
   "jest/require-top-level-describe": "error",
-  "jest/valid-describe": "error",
+  "jest/valid-describe-callback": "error",
   "jest/valid-expect": [
     "error",
     {

diff --git a/packages/mocha/rules-snapshot.json b/packages/mocha/rules-snapshot.json
@@ -7,6 +7,7 @@
     }
   ],
   "mocha/no-async-describe": "error",
+  "mocha/no-empty-description": "error",
   "mocha/no-exclusive-tests": "error",
   "mocha/no-exports": "error",
   "mocha/no-global-tests": "error",

diff --git a/packages/typescript/rules-snapshot.json b/packages/typescript/rules-snapshot.json
@@ -15,6 +15,7 @@
   "@typescript-eslint/no-extra-non-null-assertion": "error",
   "@typescript-eslint/no-extra-semi": "off",
   "@typescript-eslint/no-inferrable-types": "error",
+  "@typescript-eslint/no-loss-of-precision": "error",
   "@typescript-eslint/no-misused-new": "error",
   "@typescript-eslint/no-namespace": [
     "error",
@@ -33,6 +34,7 @@
     }
   ],
   "@typescript-eslint/no-this-alias": "error",
+  "@typescript-eslint/no-unnecessary-type-constraint": "error",
   "@typescript-eslint/no-unused-expressions": [
     "error",
     {
@@ -84,6 +86,7 @@
   "no-extra-semi": "off",
   "no-func-assign": "off",
   "no-import-assign": "off",
+  "no-loss-of-precision": "off",
   "no-new-symbol": "off",
   "no-obj-calls": "off",
   "no-redeclare": "off",