Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making preventPollingOnNetworkRestart optional in TokenListController #865

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Making preventPollingOnNetworkRestart optional in TokenListController #865

merged 1 commit into from
Jul 5, 2022

Conversation

NiranjanaBinoy
Copy link
Contributor

preventPollingOnNetworkRestart property is introduced in #861 to prevent the third party token list fetch in extension during network restart. This property should be optional as this is extension-specific and can be avoided on mobile.

@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner July 5, 2022 15:14
@NiranjanaBinoy NiranjanaBinoy self-assigned this Jul 5, 2022
danjm
danjm approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiranjanaBinoy NiranjanaBinoy merged commit e8ba9bf into main Jul 5, 2022
@NiranjanaBinoy NiranjanaBinoy deleted the prevent-token-polling-optional branch July 5, 2022 18:57
rickycodes added a commit that referenced this pull request Jul 7, 2022
@rickycodes
Merge branch 'fix-publishing-config' of github.com:metamask/controlle…
de8dcff 
…rs into fix-publishing-config

* 'fix-publishing-config' of github.com:metamask/controllers:
  30.1.0 (#866)
  Making preventPollingOnNetworkRestart optional in TokenListController (#865)
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@NiranjanaBinoy @MajorLift
Making preventPollingOnNetworkRestart optional in TokenListController (…
a267a18 
…#865)
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@NiranjanaBinoy @MajorLift
Making preventPollingOnNetworkRestart optional in TokenListController (…
2f004c1 
…#865)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NiranjanaBinoy @danjm