-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to monorepo #831
Convert to monorepo #831
Commits on May 17, 2022
-
POC - Start converting to monorepo
Completed work: * Copy a few modules to `packages/` * Upgrade Yarn to v3 * Add Yarn workspaces * Add Yarn constraints for `package.json` in root and package * Reconfigure TypeScript support new structure * Reconfigure Jest to support new structure Remaining work: * TypeDoc — it doesn't seem to support TypeScript project references, so we may have to generate docs for each package individually or figure out something else * ESLint — the `node` and `import` plugins are tripping up on imports which are aliases — we either need to disable the appropriate rules or get the plugins to recognize `tsconfig.json` appropriately
Configuration menu - View commit details
-
Copy full SHA for be212ce - Browse repository at this point
Copy the full SHA be212ceView commit details
Commits on Jun 7, 2022
-
Migrate from Yarn v1 to Yarn v3
The package manager used has been upgraded from Yarn v1 to Yarn v3. All of the steps in the migration guide [1] have been followed. Effectively everything should work the same way it did before. Closes #847 [1]: https://yarnpkg.com/getting-started/migration
Configuration menu - View commit details
-
Copy full SHA for d4a7428 - Browse repository at this point
Copy the full SHA d4a7428View commit details -
Replace
setup
script with new Yarn pluginThe old `setup` script has been replaced with a Yarn v3 plugin that will automatically run `allow-scripts` after install. We can now use `yarn install` again as normal. This was done to address a problem that happened when running `yarn setup` for the first time. If Yarn 3 wasn't installed already, it would throw an error. Yarn 3 doesn't automatically install itself until you run the `install` command directly. The `setup` script has been left behind for now so that it still works if people run it accidentally. We can remove it later once we've become accustomed to this new workflow.
Configuration menu - View commit details
-
Copy full SHA for 0da8306 - Browse repository at this point
Copy the full SHA 0da8306View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0164652 - Browse repository at this point
Copy the full SHA 0164652View commit details -
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 36afcd4 - Browse repository at this point
Copy the full SHA 36afcd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9c87b0 - Browse repository at this point
Copy the full SHA d9c87b0View commit details
Commits on Jun 9, 2022
-
Move remaining packages to packages/
Other changes: * Remove overrides in `.eslintrc` for import/*` rules * gitignore `*.tsbuildinfo` files * Fix file name of `constraints.pro` so it actually takes effect * Get `yarn lint` working
Configuration menu - View commit details
-
Copy full SHA for 30e86e2 - Browse repository at this point
Copy the full SHA 30e86e2View commit details
Commits on Jun 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6e4ea9a - Browse repository at this point
Copy the full SHA 6e4ea9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e2613a - Browse repository at this point
Copy the full SHA 5e2613aView commit details -
Configuration menu - View commit details
-
Copy full SHA for be2bbe1 - Browse repository at this point
Copy the full SHA be2bbe1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25916fd - Browse repository at this point
Copy the full SHA 25916fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b8a688 - Browse repository at this point
Copy the full SHA 8b8a688View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97d5e3f - Browse repository at this point
Copy the full SHA 97d5e3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 826e62d - Browse repository at this point
Copy the full SHA 826e62dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 416f0ad - Browse repository at this point
Copy the full SHA 416f0adView commit details
Commits on Jun 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ddab44d - Browse repository at this point
Copy the full SHA ddab44dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b4345a - Browse repository at this point
Copy the full SHA 2b4345aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ed6e03 - Browse repository at this point
Copy the full SHA 8ed6e03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6991d90 - Browse repository at this point
Copy the full SHA 6991d90View commit details -
Configuration menu - View commit details
-
Copy full SHA for f06ac0a - Browse repository at this point
Copy the full SHA f06ac0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7395afc - Browse repository at this point
Copy the full SHA 7395afcView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0ff9e2 - Browse repository at this point
Copy the full SHA c0ff9e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cff70d7 - Browse repository at this point
Copy the full SHA cff70d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 059d330 - Browse repository at this point
Copy the full SHA 059d330View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00be2cd - Browse repository at this point
Copy the full SHA 00be2cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb7e17 - Browse repository at this point
Copy the full SHA 7eb7e17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4baf34f - Browse repository at this point
Copy the full SHA 4baf34fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef9fdbd - Browse repository at this point
Copy the full SHA ef9fdbdView commit details
Commits on Jun 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fc1c892 - Browse repository at this point
Copy the full SHA fc1c892View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38a72df - Browse repository at this point
Copy the full SHA 38a72dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for c24f6db - Browse repository at this point
Copy the full SHA c24f6dbView commit details
Commits on Sep 9, 2022
-
* Fix tests * Replace isomorphic-fetch with cross-fetch (cross-fetch has better TypeScript types, and working with a non-global is generally a better experience) * Upgrade @ethereumjs/tx and @ethereumjs/common (for some reason the Common type wasn't the same between the two packages) * Move asset-related utils from controller-utils to assets-controllers
Configuration menu - View commit details
-
Copy full SHA for b61ac10 - Browse repository at this point
Copy the full SHA b61ac10View commit details -
Configuration menu - View commit details
-
Copy full SHA for c242b76 - Browse repository at this point
Copy the full SHA c242b76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cd59d2 - Browse repository at this point
Copy the full SHA 3cd59d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07bab4b - Browse repository at this point
Copy the full SHA 07bab4bView commit details
Commits on Sep 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0c34e53 - Browse repository at this point
Copy the full SHA 0c34e53View commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for afecade - Browse repository at this point
Copy the full SHA afecadeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b93feaa - Browse repository at this point
Copy the full SHA b93feaaView commit details
Commits on Oct 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 91de999 - Browse repository at this point
Copy the full SHA 91de999View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fa45f8 - Browse repository at this point
Copy the full SHA 0fa45f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbaffa9 - Browse repository at this point
Copy the full SHA fbaffa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0963bdd - Browse repository at this point
Copy the full SHA 0963bddView commit details
Commits on Oct 6, 2022
-
Confirm that all dependencies are synchronized using the same version and that no dependencies are listed multiple times in the same `package.json`.
Configuration menu - View commit details
-
Copy full SHA for 5f6205c - Browse repository at this point
Copy the full SHA 5f6205cView commit details
Commits on Oct 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b7f8c6d - Browse repository at this point
Copy the full SHA b7f8c6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a824252 - Browse repository at this point
Copy the full SHA a824252View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d1532a - Browse repository at this point
Copy the full SHA 7d1532aView commit details -
* AddressBookController and PreferencesController from user-controllers * EnsController and PhishingController from third-party-controllers
Configuration menu - View commit details
-
Copy full SHA for 90de519 - Browse repository at this point
Copy the full SHA 90de519View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0dfdf1 - Browse repository at this point
Copy the full SHA e0dfdf1View commit details
Commits on Oct 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7a568e8 - Browse repository at this point
Copy the full SHA 7a568e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f98075 - Browse repository at this point
Copy the full SHA 4f98075View commit details -
Configuration menu - View commit details
-
Copy full SHA for d294040 - Browse repository at this point
Copy the full SHA d294040View commit details -
Configuration menu - View commit details
-
Copy full SHA for 045b4e3 - Browse repository at this point
Copy the full SHA 045b4e3View commit details
Commits on Oct 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 26db827 - Browse repository at this point
Copy the full SHA 26db827View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9537b08 - Browse repository at this point
Copy the full SHA 9537b08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16f425e - Browse repository at this point
Copy the full SHA 16f425eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99ed774 - Browse repository at this point
Copy the full SHA 99ed774View commit details -
Remove the need for an extra tsconfig for tests
Some of our dependencies use ESM and need transpiling in order to use properly. We previously solved this by creating a special `tsconfig.json` file for tests where we turned on `allowJs: true`, and then using the `ts-jest/presets/js-with-ts` Jest preset as well. We don't need to do this, however, because we can specify `customExportConditions` instead, which will tell Jest that when it is resolving imports to ignore `browser` entries in `exports` and choose `cjs` instead.
Configuration menu - View commit details
-
Copy full SHA for 48fbdab - Browse repository at this point
Copy the full SHA 48fbdabView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc07abc - Browse repository at this point
Copy the full SHA fc07abcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72d47b1 - Browse repository at this point
Copy the full SHA 72d47b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7447865 - Browse repository at this point
Copy the full SHA 7447865View commit details -
Bump the version to the current version
We can't start at 0.0.0 because this repo already has tags, so `create-release-branch` will fail to run because there's no v0.0.0 tag. So the monorepo will start at the currently release version of `@metamask/controllers`.
Configuration menu - View commit details
-
Copy full SHA for ccd2e83 - Browse repository at this point
Copy the full SHA ccd2e83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 190489d - Browse repository at this point
Copy the full SHA 190489dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9e2b7a - Browse repository at this point
Copy the full SHA d9e2b7aView commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 843a5f5 - Browse repository at this point
Copy the full SHA 843a5f5View commit details
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d221d80 - Browse repository at this point
Copy the full SHA d221d80View commit details
Commits on Oct 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b3eeefd - Browse repository at this point
Copy the full SHA b3eeefdView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c700e - Browse repository at this point
Copy the full SHA d2c700eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e72cb39 - Browse repository at this point
Copy the full SHA e72cb39View commit details -
Configuration menu - View commit details
-
Copy full SHA for d501396 - Browse repository at this point
Copy the full SHA d501396View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9742ca7 - Browse repository at this point
Copy the full SHA 9742ca7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80f4ef7 - Browse repository at this point
Copy the full SHA 80f4ef7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d354a5f - Browse repository at this point
Copy the full SHA d354a5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 296cced - Browse repository at this point
Copy the full SHA 296ccedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4271859 - Browse repository at this point
Copy the full SHA 4271859View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8147c62 - Browse repository at this point
Copy the full SHA 8147c62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b7becf - Browse repository at this point
Copy the full SHA 0b7becfView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd828dd - Browse repository at this point
Copy the full SHA dd828ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for b567f43 - Browse repository at this point
Copy the full SHA b567f43View commit details
Commits on Oct 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 65961a6 - Browse repository at this point
Copy the full SHA 65961a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32286dd - Browse repository at this point
Copy the full SHA 32286ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a2819e - Browse repository at this point
Copy the full SHA 8a2819eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4be5e3a - Browse repository at this point
Copy the full SHA 4be5e3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c6ed67 - Browse repository at this point
Copy the full SHA 4c6ed67View commit details -
Configuration menu - View commit details
-
Copy full SHA for e792a1e - Browse repository at this point
Copy the full SHA e792a1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b23a926 - Browse repository at this point
Copy the full SHA b23a926View commit details -
Configuration menu - View commit details
-
Copy full SHA for e04c6ec - Browse repository at this point
Copy the full SHA e04c6ecView commit details -
Switch the Yarn constraint around so that the least version range win…
…s, fix more issues
Configuration menu - View commit details
-
Copy full SHA for 3916201 - Browse repository at this point
Copy the full SHA 3916201View commit details -
Make sure we ask people to submit a PR
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0b38110 - Browse repository at this point
Copy the full SHA 0b38110View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5589099 - Browse repository at this point
Copy the full SHA 5589099View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b35da7 - Browse repository at this point
Copy the full SHA 6b35da7View commit details -
Assign a return type to setTimeout that works in both Node and browse…
…r envs In Node, `setTimeout` returns NodeJS.Timer, whereas in the browser, `setTimeout` returns a number. So we if assign a type of NodeJS.Timer to the variable here (see diff), `tsserver` will be cool with it, `tsc` will be cool with it, but Jest will not be cool with it (because we've instructed the `transaction-controller` tests to run within a jsdom environment, and so `@types/node` [somehow] does not apply in this case). Also ensure that when we use the Jest `jsdom` environment we clear out the existing options we'd set for the `node` environment, just so we know that Jest isn't trying to do something we don't expect it to.
Configuration menu - View commit details
-
Copy full SHA for 25a7afa - Browse repository at this point
Copy the full SHA 25a7afaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 655d7a0 - Browse repository at this point
Copy the full SHA 655d7a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41b1c56 - Browse repository at this point
Copy the full SHA 41b1c56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 113c7a0 - Browse repository at this point
Copy the full SHA 113c7a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac20a31 - Browse repository at this point
Copy the full SHA ac20a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0476bfb - Browse repository at this point
Copy the full SHA 0476bfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c63a2a - Browse repository at this point
Copy the full SHA 6c63a2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1db12d - Browse repository at this point
Copy the full SHA d1db12dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6959246 - Browse repository at this point
Copy the full SHA 6959246View commit details
Commits on Oct 15, 2022
-
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee323bd - Browse repository at this point
Copy the full SHA ee323bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6d186d - Browse repository at this point
Copy the full SHA b6d186dView commit details
Commits on Oct 31, 2022
-
Merge remote-tracking branch 'origin/main' into monorepo-poc
Configuration menu - View commit details
-
Copy full SHA for 5286350 - Browse repository at this point
Copy the full SHA 5286350View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e36aa9 - Browse repository at this point
Copy the full SHA 2e36aa9View commit details
Commits on Nov 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 839944e - Browse repository at this point
Copy the full SHA 839944eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a4b24 - Browse repository at this point
Copy the full SHA 77a4b24View commit details
Commits on Nov 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f3770ba - Browse repository at this point
Copy the full SHA f3770baView commit details -
Configuration menu - View commit details
-
Copy full SHA for a08ab7e - Browse repository at this point
Copy the full SHA a08ab7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3de137d - Browse repository at this point
Copy the full SHA 3de137dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a0d96c - Browse repository at this point
Copy the full SHA 4a0d96cView commit details
Commits on Nov 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3c824fd - Browse repository at this point
Copy the full SHA 3c824fdView commit details -
Merge remote-tracking branch 'origin/main' into monorepo-poc
* origin/main: Add subject type and method to get metadata by origin (#950)
Configuration menu - View commit details
-
Copy full SHA for 6326c50 - Browse repository at this point
Copy the full SHA 6326c50View commit details -
* Add actionlint, which must pass before other jobs can run * Only run release workflow after lint/build/test passes
Configuration menu - View commit details
-
Copy full SHA for cc9bdbb - Browse repository at this point
Copy the full SHA cc9bdbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c2cad8 - Browse repository at this point
Copy the full SHA 6c2cad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75cfcb4 - Browse repository at this point
Copy the full SHA 75cfcb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 407a17f - Browse repository at this point
Copy the full SHA 407a17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e43457a - Browse repository at this point
Copy the full SHA e43457aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b65b4ae - Browse repository at this point
Copy the full SHA b65b4aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb2670e - Browse repository at this point
Copy the full SHA eb2670eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 259f7b1 - Browse repository at this point
Copy the full SHA 259f7b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40a3e1e - Browse repository at this point
Copy the full SHA 40a3e1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 743f434 - Browse repository at this point
Copy the full SHA 743f434View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9f960a - Browse repository at this point
Copy the full SHA c9f960aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 853e460 - Browse repository at this point
Copy the full SHA 853e460View commit details
Commits on Nov 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 31cf514 - Browse repository at this point
Copy the full SHA 31cf514View commit details -
Fix JSDoc for ContactEntry interface
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Configuration menu - View commit details
-
Copy full SHA for 43ca97e - Browse repository at this point
Copy the full SHA 43ca97eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b24bc7 - Browse repository at this point
Copy the full SHA 1b24bc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4714429 - Browse repository at this point
Copy the full SHA 4714429View commit details -
Configuration menu - View commit details
-
Copy full SHA for 750ac80 - Browse repository at this point
Copy the full SHA 750ac80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0691206 - Browse repository at this point
Copy the full SHA 0691206View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca16296 - Browse repository at this point
Copy the full SHA ca16296View commit details -
Configuration menu - View commit details
-
Copy full SHA for a015279 - Browse repository at this point
Copy the full SHA a015279View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bf6120 - Browse repository at this point
Copy the full SHA 3bf6120View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a3b749 - Browse repository at this point
Copy the full SHA 3a3b749View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b957f8 - Browse repository at this point
Copy the full SHA 0b957f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c1fbe - Browse repository at this point
Copy the full SHA b7c1fbeView commit details