Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Convert to monorepo #322

Closed
rekmarks opened this issue Dec 17, 2020 · 4 comments
Closed

[Epic] Convert to monorepo #322

rekmarks opened this issue Dec 17, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request Epic

Comments

@rekmarks
Copy link
Member

By iterating in the approval controller, I've bumped us up two major versions, and with #321, it will be a third. We should publish all controllers as individual packages, and turn this into a monorepo.

@rekmarks rekmarks added the enhancement New feature or request label Dec 17, 2020
@brad-decker
Copy link
Contributor

When using a monorepo, my preferred practice for packages is to keep the versions linked so that there is never a discrepancy in version number across packages. React, and babel are good examples of this. I don't think we want our controllers in different version states; thus, it might not solve the particular problem stated in the description.

@brad-decker
Copy link
Contributor

brad-decker commented Dec 17, 2020

This would also require a significant rethinking of the messaging proposal to have each controller in its separate package.

this is already necessary, but the original comment stands. :D

@rekmarks rekmarks changed the title Turn this into a monorepo and publish each controller as an individual package Turn this into a monorepo and publish each controller as an individual package? Aug 19, 2021
@mcmire
Copy link
Contributor

mcmire commented Mar 31, 2022

Converting this repo into a monorepo (with all controllers placed into their own package) is now a goal of the newly established core team and it is something we will be aiming to complete by end of Q2.

As it relates to the discussion above, we have decided that we do not want to synchronize versions among all of the packages in this repo. Eventually, this repo will be renamed core and will house other packages which are not related to controllers. We want to be able to give ourselves and product teams the independence to maintain packages with as little coupling as possible.

Consult this document for more information on our plan going forward.

@mcmire mcmire changed the title Turn this into a monorepo and publish each controller as an individual package? Convert to monorepo May 11, 2022
@mcmire mcmire added the Epic label May 11, 2022
@mcmire mcmire changed the title Convert to monorepo [Epic] Convert to monorepo Aug 18, 2022
@Gudahtt Gudahtt self-assigned this Oct 27, 2022
@Gudahtt
Copy link
Member

Gudahtt commented Jan 19, 2023

This was completed in #831

@Gudahtt Gudahtt closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic
Projects
None yet
Development

No branches or pull requests

4 participants