Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore derived key default exportable to false, provide option to make exportable #38

Merged
merged 1 commit into from Nov 14, 2022

Conversation

darkwing
Copy link
Contributor

Before #29, the derived key from keyFromPassword was never exportable. This PR returns that default inability to export but allows the developer to cite if they would like it exportable.

@darkwing darkwing requested a review from a team as a code owner November 14, 2022 14:40
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch

@darkwing darkwing merged commit 27c0cb4 into main Nov 14, 2022
@darkwing darkwing deleted the export-key-bool branch November 14, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants