-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub actions to match module template #31
Conversation
731780c
to
03200dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prepack script is required for the release workflow: https://github.com/MetaMask/metamask-module-template/blob/e53ced0d65d2295557b37d5f9dfce406220b19c3/scripts/prepack.sh
Make sure to update the package.json
entry too.
Ah I forgot! I checked for the script used by the doc publishing but not for that one, good catch. |
The GitHub actions have been updated to match the latest used in the module template, with some exceptions. The require-additional-reviewer action was omitted because it's broken for forks, and the documentation-related steps have been omitted because this repository does not yet have API documentation. See: https://github.com/MetaMask/metamask-module-template/tree/e53ced0d65d2295557b37d5f9dfce406220b19c3/.github/workflows
e43b688
to
6451e06
Compare
Resolved in 6451e06 |
The publishing instructions in the README have been updated to reflect changes introduced in #31. We forgot to update the README in that PR. The release instructions should now match those in the module template.
The publishing instructions in the README have been updated to reflect changes introduced in #31. We forgot to update the README in that PR. The release instructions should now match those in the module template.
The GitHub actions have been updated to match the latest used in the module template, with some exceptions. The require-additional-reviewer action was omitted because it's broken for forks, and the documentation-related steps have been omitted because this repository does not yet have API documentation.
See: https://github.com/MetaMask/metamask-module-template/tree/e53ced0d65d2295557b37d5f9dfce406220b19c3/.github/workflows