Update GitHub actions to match module template #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
update-actions-to-match-module-template
branch
2 times, most recently
from
731780c
to
03200dc
Compare
Mrtenz
requested changes
Nov 4, 2022
There was a problem hiding this comment.
The prepack script is required for the release workflow: https://github.com/MetaMask/metamask-module-template/blob/e53ced0d65d2295557b37d5f9dfce406220b19c3/scripts/prepack.sh
Make sure to update the package.json entry too.
|
Ah I forgot! I checked for the script used by the doc publishing but not for that one, good catch. |
The GitHub actions have been updated to match the latest used in the module template, with some exceptions. The require-additional-reviewer action was omitted because it's broken for forks, and the documentation-related steps have been omitted because this repository does not yet have API documentation. See: https://github.com/MetaMask/metamask-module-template/tree/e53ced0d65d2295557b37d5f9dfce406220b19c3/.github/workflows
Gudahtt
force-pushed
the
update-actions-to-match-module-template
branch
from
e43b688
to
6451e06
Compare
|
Resolved in 6451e06 |
Mrtenz
approved these changes
Nov 4, 2022
Gudahtt
added a commit
that referenced
this pull request
Nov 9, 2022
The publishing instructions in the README have been updated to reflect changes introduced in #31. We forgot to update the README in that PR. The release instructions should now match those in the module template.
Gudahtt
added a commit
that referenced
this pull request
Nov 9, 2022
The publishing instructions in the README have been updated to reflect changes introduced in #31. We forgot to update the README in that PR. The release instructions should now match those in the module template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub actions have been updated to match the latest used in the module template, with some exceptions. The require-additional-reviewer action was omitted because it's broken for forks, and the documentation-related steps have been omitted because this repository does not yet have API documentation.
See: https://github.com/MetaMask/metamask-module-template/tree/e53ced0d65d2295557b37d5f9dfce406220b19c3/.github/workflows