Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.7.0 #139

Closed
wants to merge 2 commits into from
Closed

2.7.0 #139

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 2.7.0.

mcmire and others added 2 commits December 13, 2022 15:05
Currently, this tool expects the version in a release header to be a
version that looks like `<major>.<minor>.<patch>` and rejects other
formats. However, it may be useful to publish a prerelease version of a
package so that integration with other products/services can be tested
in a more "live" manner, particularly if that package is a part of a
monorepo. A prerelease version looks like
`<major>.<minor>.<patch>-<prerelease identifier>.<number>`, where
`<prerelease identifier>` can be an arbitrary word like `alpha`, `beta`,
or `rc`. This commit allows such versions.
@legobeat
Copy link
Contributor

legobeat commented Dec 13, 2022

The intention here is to make the changes in #130 available in https://github.com/MetaMask/action-publish-release prior to deprecating nodejs v12 there.

Created a new 2.x branch from v2.6.1 which this is targeting instead of main.

@legobeat legobeat changed the base branch from main to v2.x December 13, 2022 06:28
@legobeat legobeat marked this pull request as ready for review December 13, 2022 06:28
@legobeat legobeat requested a review from a team as a code owner December 13, 2022 06:28
@mcmire
Copy link
Contributor

mcmire commented Dec 13, 2022

@legobeat I am not opposed to this, but as an alternative, would it make sense to deprecate nodejs 12 and also bump auto-changelog in the same release of action-publish-release? Or is there something you found that would prohibit us from doing this? Sorry if I am missing context here.

@legobeat
Copy link
Contributor

@mcmire No, you're right. Just wanted to make use of this feature now and figured a major release may be a bigger review and that this could be processed smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants