Enable ignoring fields by using [NonSerialized] #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessagePack-CSharp is nice enough to simply skip serialization of properties and fields tagged with
[IgnoreDataMember]and[IgnoreMember]without fuzz, which seems appropriate.Since .NET also contains the
[NonSerialized]attribute, which I believe is the oldest "dear serializer, please ignore this field"-type of serializer hint, it seems natural to also ignore these. This will in turn make migration from the oldBinaryFormatter(which is deprecated and no longer exists in .NET 9) much easier, because[NonSerialized]was how it was told to skip specific fields.This PR adds an extra case to the
CreateEmittableMembermethod ofDynamicObjectResolver, which causes fields decorated with[NonSerialized]to be ignored. It's backed up by an additional testSerialize_WithNonSerializedAttributeinDataContractTest.