Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source generated formatters for records with string keys #1798

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

dmitry-bym
Copy link

@dmitry-bym dmitry-bym commented Apr 13, 2024

Just added fix, all previous tests succesfull but for now im trying to make new ones work, so it's draft for now. Just to be clear I assume that the name of the parameter and the property are the same but in different case.

I didn't want to change logic with stringKey collection logic so i just changed key in ctor lookup, the simpliest fix i see

Fixes #1797

@dmitry-bym dmitry-bym changed the base branch from master to develop April 13, 2024 05:23
@AArnott AArnott changed the title Fix 1797 Fix source generated formatters for records with string keys Apr 13, 2024
@dmitry-bym dmitry-bym marked this pull request as ready for review April 13, 2024 15:28
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The fix and the tests look spot on!

@AArnott AArnott added this to the v3.0 milestone Apr 13, 2024
@AArnott AArnott merged commit c07dc04 into MessagePack-CSharp:develop Apr 13, 2024
4 of 5 checks passed
@dmitry-bym
Copy link
Author

@AArnott No problem! could you tell me when there will be packages with these changes i just realy need that in my project?

@AArnott
Copy link
Collaborator

AArnott commented Apr 13, 2024

You can get the packages from our CI feed: https://dev.azure.com/ils0086/MessagePack-CSharp/_artifacts/feed/MessagePack-CI/NuGet/MessagePack/overview/3.0.46-alpha

Note though that as a CI feed, packages may not be retained forever, so ideally you'd consume them through your own feed that would retain it there.
I'm afraid it's still too early to issue a prerelease to nuget.org as things are really in flux in the develop branch.

I suppose if you want, given a good look at your fix, if you want to cherrypick it to our master branch I can merge it there and we can issue another release from there to nuget.org. If the test doesn't port over well, you can drop it since we have it in develop.

@dmitry-bym
Copy link
Author

Thanks! will use pack from ur ci feed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants