Compute formatters only if elements are there

MessagePack-CSharp · Apr 22, 2024 · 6b4beaf · 6b4beaf
1 parent fb0bb13
commit 6b4beaf
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Formatters/DictionaryFormatter.cs b/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Formatters/DictionaryFormatter.cs
@@ -78,10 +78,6 @@ public void Serialize(ref MessagePackWriter writer, TDictionary? value, MessageP
             }
             else
             {
-                IFormatterResolver resolver = options.Resolver;
-                IMessagePackFormatter<TKey>? keyFormatter = resolver.GetFormatterWithVerify<TKey>();
-                IMessagePackFormatter<TValue>? valueFormatter = resolver.GetFormatterWithVerify<TValue>();
-
                 var len = reader.ReadMapHeader();
 
                 TIntermediate dict = this.Create(len, options);
@@ -90,6 +86,9 @@ public void Serialize(ref MessagePackWriter writer, TDictionary? value, MessageP
                 {
                     if (len > 0)
                     {
+                        IFormatterResolver resolver = options.Resolver;
+                        IMessagePackFormatter<TKey>? keyFormatter = resolver.GetFormatterWithVerify<TKey>();
+                        IMessagePackFormatter<TValue>? valueFormatter = resolver.GetFormatterWithVerify<TValue>();
                         for (int i = 0; i < len; i++)
                         {
                             reader.CancellationToken.ThrowIfCancellationRequested();