Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit an empty file when leaving a file input blank #270

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Submit an empty file when leaving a file input blank #270

merged 2 commits into from
Apr 3, 2019

Commits on Mar 21, 2019

  1. Remove file field in test__request 

    This is to test the `application/x-www-form-urlencoded` data-type
when the form contains no file input field.

Otherwise, the data-type is set to `multipart/form-data`,
which will be tested in `test__request_file`.
    @senabIsShort
    senabIsShort committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    0905ac6 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2019

  1. Sumbit an empty value when a file input is left blank. 

    Fixes #250
Pass both filename and content to match browser behavior.

Add test for lack of file input :
Test that an empty filename is sent in such cases.
Parametrized test__request_file() in order to avoid code duplication
    @senabIsShort
    senabIsShort committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    366f84a View commit details
    Browse the repository at this point in the history