Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to not edit disabled #254

Closed
wants to merge 3 commits into from
Closed

added ability to not edit disabled #254

wants to merge 3 commits into from

Conversation

rational-kunal
Copy link

Added dev_op boolean variable to Form
if dev_op is True then you can edit disabled inputs
else dev_op is False then you cant edit disabled inputs

@moy
Copy link
Collaborator

moy commented Dec 3, 2018

We have automatic testing, and as you see there are issues to fix in your code (at least flake8 formatting issues). This would also require documentation and more tests (we have a strict 100% coverage policy).

But as I said in #248, I don't think this is the right approach. If you think it is, then please rewrite the commit message to explain 1) the issue you are trying to solve and 2) why you think your modifications are the best way to fix this issue.

@moy
Copy link
Collaborator

moy commented Dec 6, 2018

As I wrote in #248 (comment), I don't think edition of disabled fields is the problem. The first thing to fix is the form submission.

Also, the Travis build fails, we can't merge a PR with test failures, sorry.

@rational-kunal
Copy link
Author

How can I add test case for this issue ?
There is no disabled form field in httpbin !

@moy
Copy link
Collaborator

moy commented Feb 14, 2019

I believe 685eb6e fixed the main problem with disabled fields, so let's close this.

@moy moy closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants