test_form.py: fix test_choose_submit_twice #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a BeautifulSoup object is constructed from an html string, it will standardize the html. In this case, since the input html was just a raw <form>, it added <html> and <body> tags around it. Since the `Form` ctor now demands that it is passed a <form> element, we need to extract <form> from the object BeautifulSoup constructs to pass to the `Form` ctor.
moy
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
ACK.
The absence of check in some case was rather clearly a bug. We've somehow broken the backward compatibility by making the check stricter, but I think it's OK like that.
Another option is to turn the check into a warning, so that code that badly use it still works, but with a warning message.
|
I like your idea of making it a warning. Perhaps it could say something like this?
... or whatever the correct terminology is... |
|
Sounds good. I'd just write "that is a at its root level". I first read your sentence as "the tag should be the toplovel of the document" which couldn't be right. And perhapss/will be/may become/, if we don't want to commit to changing it later.
Care to make a patch, or shall I? |
hemberger
added a commit
to hemberger/MechanicalSoup
that referenced
this pull request
Aug 29, 2018
In 4e3fd3c, passing a bs4.element.Tag that was not a "form" to the constructor of `Form` was escalated to a `LinkNotFoundError`. Since this breaks backwards compatibility, we soften the error to a deprecation warning (using the warnings library). In a future version, this may become an error again. However, `StatefulBrowser.select_form` has always raised an error in this case since it began accepting a bs4.element.Tag in a5dec34, so we continue to do so there. Related to MechanicalSoup#228.
moy
pushed a commit
that referenced
this pull request
Aug 30, 2018
In 4e3fd3c, passing a bs4.element.Tag that was not a "form" to the constructor of `Form` was escalated to a `LinkNotFoundError`. Since this breaks backwards compatibility, we soften the error to a deprecation warning (using the warnings library). In a future version, this may become an error again. However, `StatefulBrowser.select_form` has always raised an error in this case since it began accepting a bs4.element.Tag in a5dec34, so we continue to do so there. Related to #228.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a BeautifulSoup object is constructed from an html string,
it will standardize the html. In this case, since the input html
was just a raw
<form>, it added<html>and<body>tags around it.Since the
Formctor now demands that it is passed a<form>element,we need to extract
<form>from the object BeautifulSoup constructsto pass to the
Formctor.Side question: The sanity check on
Formbeing passed a<form>is in principle a good one, since I have seen plenty of errors that resulted from passing something that wasn't (or didn't even contain) a form to theFormctor. But is it too restrictive? Should we expect that passing a<html><body><form>...</form></body></html>toFormshould work? And if so, could we allow such a thing without also letting people make more egregious mistakes?