Skip to content

Commit

Permalink
Fix rSAFor WPT dual-write test case
Browse files Browse the repository at this point in the history
The purpose of this test is to verify that a successful
requestStorageAccessFor() call also sets a storage-access grant so
that requestStorageAccess() should be resolved without a user gesture.
However the test was testing this behavior in a same-origin iframe,
in which case requestStorageAccess() is resolved not due to the
existing grant.

Change-Id: Ic16702271d1bed1f4faaacdd3ebef0dc152fecb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4721492
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Auto-Submit: Shuran Huang <shuuran@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175699}
  • Loading branch information
shuranhuang authored and chromium-wpt-export-bot committed Jul 26, 2023
1 parent 415fb40 commit e432c73
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ promise_test(
'granted');

const frame = await CreateFrame(
'/storage-access-api/resources/script-with-cookie-header.py?script=embedded_responder.js');
altOrigin + '/storage-access-api/resources/script-with-cookie-header.py?script=embedded_responder.js');

await RunCallbackWithGesture(() => document.requestStorageAccessFor(altOrigin));
assert_true(await RequestStorageAccessInFrame(frame));
Expand Down

0 comments on commit e432c73

Please sign in to comment.