Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test with oauth2 code to reproduce #180 #181

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jwillemsen
Copy link
Contributor

* tests/test_config_flow.py:

@jwillemsen
Copy link
Contributor Author

Reproducer for #180

@jwillemsen
Copy link
Contributor Author

I made this working for my integration test, see jwillemsen/daikin_onecta#94, I will try to find out what is the change that is required here to fix this CI

@MatthewFlamm
Copy link
Owner

I'm not that familiar with oath2 in homeassistant. I would assume that you have to register something or add some code to the integration that is tested?

@jwillemsen
Copy link
Contributor Author

I still haven't figured out why it now works with my custom integration, it looks it is not just the change in my test code, when I have some spare time I will try if I can find some necessary code that needs to be added to the test integration as part of this repo, something is missing somewhere

@MatthewFlamm MatthewFlamm marked this pull request as draft March 18, 2024 16:05
@MatthewFlamm
Copy link
Owner

Made this draft as this doesn't look close to implementing. I highly suspect code needs to be added to custom_components/ here for the test to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants