Merge pull request rspec#2732 from rspec/fix-return-status-for-bisect

Fix bug with bisect and custom error codes
MatheusRich · May 30, 2020 · 8feb454 · 8feb454
2 parents 10a77ee + 3d69cb8
commit 8feb454
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/rspec/core/invocations.rb b/lib/rspec/core/invocations.rb
@@ -37,7 +37,7 @@ def call(options, err, out)
             runner, options.args, formatter
           )
 
-          success ? 0 : 1
+          success ? 0 : runner.configuration.failure_exit_code
         end
 
       private

diff --git a/spec/rspec/core/invocations_spec.rb b/spec/rspec/core/invocations_spec.rb
@@ -111,6 +111,16 @@ def run_invocation
 
           expect(exit_code).to eq(1)
         end
+
+        context "with a custom failure code set" do
+          it "returns the custom failure code" do
+            in_sub_process do
+              RSpec.configuration.failure_exit_code = 42
+              exit_code = run_invocation
+              expect(exit_code).to eq(42)
+            end
+          end
+        end
       end
 
       context "and the verbose option is specified" do