Trajectory Endpoint #1845
Trajectory Endpoint #1845
Conversation
This reverts commit 6251e48.
This reverts commit bf9692a.
…/optimade-python-tools into JPBergsma/add_metadata
This reverts commit 68f14d3.
…ing about receiving too many arguments.
removed duplicate requirement
* Use Python 3.9 as the 'base' CI version for linting * Update pre-commit hooks * Run `pyupgrade --py39-plus` to upgrade legacy annotations * Add `--exit-non-zero-on-fix` for ruff Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> * Use f-string over format Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> --------- Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
|
Looks great so far @JPBergsma!
There's no reason we can't have the typing stuff in 0.25.x (indeed I'm still running into lots of issues with the new version) -- if I cherry pick the commits into 0.25.x we can see how difficult it would be to rebase (I'll take copies of your branch that we can restore to). |
There was a problem hiding this comment.
Just rebased this PR after cherry-picking the big type hint change back into 0.25.x, so this looks more manageable now. Let me know when you want a full review @JPBergsma, left a few comments below until then
| @@ -4,6 +4,7 @@ flake8==6.1.0 | |||
| invoke==2.2.0 | |||
| isort==5.12.0 | |||
| jsondiff==2.0.0 | |||
| jsonlines>=3.1 | |||
There was a problem hiding this comment.
| jsonlines>=3.1 |
Doesn't need to be in both places
| "numpy>=1.20", | ||
| "jsonlines>=3.1", |
There was a problem hiding this comment.
I think maybe these should still be optional server deps, or special trajectories deps?
| @@ -1 +1 @@ | |||
| web: uvicorn optimade.server.main:app --host 0.0.0.0 --port $PORT | |||
| web: --host 0.0.0.0 --port $PORT | |||
There was a problem hiding this comment.
Why was this necessary? I think fly might get confused
This PR is mainly created to make it easier to find where I have made the changes for the trajectory endpoint. This code does not yet have the quality that I would think it needs to be merge ready.
The procfile has been adjusted so a demo can be run on the Matcloud server.
It looks like the dropping of the python 3.8 typing was reverted the 0.25.x branch but it is still in this branch. So I am not sure what I should do with that for now.