JPBergsma/partial data #1812
Draft
JPBergsma/partial data #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6251e48.
This reverts commit bf9692a.
…/optimade-python-tools into JPBergsma/add_metadata
JPBergsma
force-pushed
the
JPBergsma/Partial_data
branch
from
774cbc5
to
2f76149
Compare
JPBergsma
force-pushed
the
JPBergsma/Partial_data
branch
from
2f76149
to
3be7d54
Compare
JPBergsma
force-pushed
the
JPBergsma/Partial_data
branch
from
b1b66c4
to
075ef06
Compare
removed duplicate requirement
* Use Python 3.9 as the 'base' CI version for linting * Update pre-commit hooks * Run `pyupgrade --py39-plus` to upgrade legacy annotations * Add `--exit-non-zero-on-fix` for ruff Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> * Use f-string over format Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> --------- Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
JPBergsma
force-pushed
the
JPBergsma/Partial_data
branch
from
7cca9c5
to
bf29459
Compare
Codecov Report
@@ Coverage Diff @@
## master #1812 +/- ##
==========================================
- Coverage 90.68% 90.65% -0.03%
==========================================
Files 74 78 +4
Lines 4616 4956 +340
==========================================
+ Hits 4186 4493 +307
- Misses 430 463 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Hi @JPBergsma, I've just changed the base branch of this PR and others to the new 0.25.x branch until we can port things over. I would suggest you keep working as you see fit, and we can then try to port your changes over to the new format once finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to implement the partial data mechanism and the JSON lines return format as described in PR#467, and PR#481