Add meta field to entry model #1698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
+ Coverage 90.68% 90.78% +0.09%
==========================================
Files 74 74
Lines 4616 4665 +49
==========================================
+ Hits 4186 4235 +49
Misses 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 6251e48.
This reverts commit bf9692a.
…/optimade-python-tools into JPBergsma/add_metadata
ml-evs
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Thanks @JPBergsma, this is nice. Very minor suggestions below.
Let's have a chat on Monday about the best way of merging this (and the other 1.2 features).
update description property_metadata field Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
This reverts commit 68f14d3.
removed duplicate requirement
* Use Python 3.9 as the 'base' CI version for linting * Update pre-commit hooks * Run `pyupgrade --py39-plus` to upgrade legacy annotations * Add `--exit-non-zero-on-fix` for ruff Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> * Use f-string over format Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> --------- Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to add support for the metadata field as described in issue #1697
It is still a work in progress, as I still need to add tests and validators, but comments are welcome.