Draft of SQLAlchemy-based EntryCollection
#1656
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jens Jørgen Mortensen <jjmortensen@users.noreply.github.com>
ml-evs
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
- Coverage 91.04% 87.11% -3.94%
==========================================
Files 74 75 +1
Lines 4580 4787 +207
==========================================
Hits 4170 4170
- Misses 410 617 +207
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the initial work by @jensj at https://gitlab.com/jensj/ase-optimade, this PR introduces a SQLAlchemy-based backend for the reference server. This collection is intended to be used "from scratch", by e.g., ingesting OPTIMADE data into a new set of tables, rather than attaching to an existing database of a given format. It has no corresponding filter transformer class as filtering requires access to the table metadata, so as such, it is bundled as part of the collection.
Still very WIP and currently only handles structure data (not links etc).