Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for fuzzy list comparison #1426

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Adding support for fuzzy list comparison #1426

wants to merge 1 commit into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 6, 2022

Closes #1246.

Still much to-do:

  • Add tests of example queries from spec
  • Update grammar to allow constructs
  • Implement or add errors for attempting to use the construct

@ml-evs ml-evs added grammar Concerns the Lark grammar files server Issues pertaining to the example server implementation on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Dec 6, 2022
@ml-evs ml-evs changed the title Support fuzzy list comparison Adding support for fuzzy list comparison Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA will be requested when the pull request is marked ready for review CasperWA is a code owner

@JPBergsma JPBergsma Awaiting requested review from JPBergsma JPBergsma will be requested when the pull request is marked ready for review JPBergsma is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
grammar Concerns the Lark grammar files on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 server Issues pertaining to the example server implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support fuzzy comparison lists in grammar
1 participant
@ml-evs