Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new symmetry fields to structure model #1422

Draft
wants to merge 7 commits into
base: 0.25.x
Choose a base branch
from
Draft

Add new symmetry fields to structure model #1422

wants to merge 7 commits into from
+356 −143

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 6, 2022 •
edited

Closes #1415, pending future changes to the specification on symmetry.

To-do:

@ml-evs ml-evs force-pushed the ml-evs/add_space_group_support branch from 5a8559c to ea2009b Compare December 6, 2022 19:45
@ml-evs ml-evs added schema Concerns the schema models models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 on-hold For PRs/issues that are on-hold for an unspecified time labels Dec 6, 2022
@ml-evs ml-evs changed the title Add space_group_hall and space_group_it_number to structure model Add new symmetry fields to structure model Dec 20, 2023
@ml-evs ml-evs changed the base branch from master to 0.25.x December 20, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA will be requested when the pull request is marked ready for review CasperWA is a code owner

@JPBergsma JPBergsma Awaiting requested review from JPBergsma JPBergsma will be requested when the pull request is marked ready for review JPBergsma is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
models For issues related to the pydantic models directly on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for space group definitions
1 participant
@ml-evs