Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable request_delay support to server and models #1420

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add configurable request_delay support to server and models #1420

wants to merge 1 commit into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 6, 2022 •
edited

Closes #1418.

@ml-evs ml-evs added the OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 label Dec 6, 2022
@ml-evs ml-evs added this to the OPTIMADE v1.2 milestone Dec 6, 2022
@ml-evs ml-evs added schema Concerns the schema models server Issues pertaining to the example server implementation models For issues related to the pydantic models directly labels Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited

Codecov Report

Merging #1420 (8ca2fd0) into master (a8c84c5) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   91.43%   91.41%   -0.03%     
==========================================
  Files          74       74              
  Lines        4392     4401       +9     
==========================================
+ Hits         4016     4023       +7     
- Misses        376      378       +2
Flag Coverage Δ
project 91.41% <80.00%> (-0.03%) ⬇️
validator 91.50% <80.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/server/routers/utils.py 95.68% <50.00%> (-0.81%) ⬇️
optimade/server/config.py 92.92% <83.33%> (-0.62%) ⬇️
optimade/models/optimade_json.py 95.83% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ml-evs ml-evs added the on-hold For PRs/issues that are on-hold for an unspecified time label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA will be requested when the pull request is marked ready for review CasperWA is a code owner

@JPBergsma JPBergsma Awaiting requested review from JPBergsma JPBergsma will be requested when the pull request is marked ready for review JPBergsma is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
models For issues related to the pydantic models directly on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models server Issues pertaining to the example server implementation
Projects
None yet
Milestone
OPTIMADE v1.2
Development

Successfully merging this pull request may close these issues.

Support new meta->request_delay field
1 participant
@ml-evs