Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /files endpoint and entry type #1414

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add /files endpoint and entry type #1414

wants to merge 8 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 6, 2022 •
edited

Building from @JPBergsma's work, this PR adds the files endpoint and entry type.

This should not be merged until we have decided if we can support multiple OPTIMADE versions from a single optimade-python-tools version, but in the meantime, this can be used to generate the OpenAPI schemata for v1.2.

To-do:

  • models
  • server code
  • OpenAPI schemas
  • Testing
  • Docs updates

@ml-evs ml-evs added schema Concerns the schema models server Issues pertaining to the example server implementation models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Dec 6, 2022
@ml-evs ml-evs changed the title Add files endpoint Add /files endpoint and entry type Dec 6, 2022
@ml-evs ml-evs added this to the OPTIMADE v1.2 milestone Dec 6, 2022
@ml-evs ml-evs added the on-hold For PRs/issues that are on-hold for an unspecified time label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA will be requested when the pull request is marked ready for review CasperWA is a code owner

@JPBergsma JPBergsma Awaiting requested review from JPBergsma JPBergsma will be requested when the pull request is marked ready for review JPBergsma is a code owner

@markus1978 markus1978 Awaiting requested review from markus1978 markus1978 will be requested when the pull request is marked ready for review markus1978 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
models For issues related to the pydantic models directly on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models server Issues pertaining to the example server implementation
Projects
None yet
Milestone
OPTIMADE v1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ml-evs @JPBergsma