cargo: fix jemalloc dependencies #27074
Conversation
|
@benesch, is this still up to date with recent changes regarding jemalloc?
|
There was a problem hiding this comment.
We need to go the other way with this! As described here, those dependencies are not unused but load bearing for selecting the correct memory allocator by default: #27067
I'll push up a revision to this PR that marks them as ignored in the unused dependency list.
benesch
force-pushed
the
cargo/remove-unused-deps
branch
from
14c1aaf
to
683e34f
Compare
nrainer-materialize
changed the title
benesch
force-pushed
the
cargo/remove-unused-deps
branch
2 times, most recently
from
95db186
to
7e2ebbe
Compare
ci/test/lint-deps.sh
Outdated
| | tail -r \ | ||
| | awk -F: 'BEGIN {f=-1} /^([0-9]+):'"$crate"'/{print;f=$0-1} f==$1{print;f=f-1}' \ | ||
| | tac) | ||
| | tail -r) | ||
| # Only print crate and dependency chain if there is a dependency. |
There was a problem hiding this comment.
Is tail -r really a thing?
tail -r
tail: invalid option -- 'r'
Try 'tail --help' for more information.
There was a problem hiding this comment.
Probably only on macOS? 🤔
benesch
force-pushed
the
cargo/remove-unused-deps
branch
from
7e2ebbe
to
1abcac2
Compare
This fixes https://buildkite.com/materialize/nightly/builds/7762#018f744c-16d6-4bde-bbb1-d9e8ffcf2e06.