adapter: mz_object_fully_qualified_names includes database and schema IDs #27069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
approved these changes
May 14, 2024
src/catalog/src/builtin.rs
Outdated
| @@ -3304,18 +3304,20 @@ UNION ALL | |||
| } | |||
| }); | |||
|
|
|||
| pub static MZ_OBJECT_FULLY_QUALIFIED_NAMES: Lazy<BuiltinView> = Lazy::new(|| BuiltinView { | |||
| pub static MZ_OBJECT_FULLY_QUALIFIED_NAMES: Lazy<BuiltinView> = Lazy::new(|| { | |||
| BuiltinView { | |||
There was a problem hiding this comment.
Something strange happened here.
RobinClowers
force-pushed
the
fully-qualified-names-view-includes-ids
branch
3 times, most recently
from
7fce374
to
45a88f9
Compare
maddyblue
approved these changes
May 14, 2024
RobinClowers
force-pushed
the
fully-qualified-names-view-includes-ids
branch
from
45a88f9
to
c9f99d4
Compare
morsapaes
reviewed
May 14, 2024
RobinClowers
force-pushed
the
fully-qualified-names-view-includes-ids
branch
from
091e90e
to
81ca910
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The console often ends up joining mz_databases and mz_schemas manually, because we need the database and or schema IDs.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.