-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.0.99: global id migration fix #27040
v.0.99: global id migration fix #27040
Conversation
…tstrap" This reverts commit 7d348b6. In trying to release v0.99.0, we discovered that v0.98.6 contained a bug that failed to adequately adjust all items' GlobalIds to use GlobalId's PartialOrd implementation to express dependencies.
49e29ee
to
aaa43c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only took a cursory glance, let me know if you want a closer review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should the soft assert be a not soft assert?
@maddyblue Yeah––that is a good point and one I thought about for a while. One of the things I've been trying to do is avoid panicking This strategy was actually working; we'd been receiving Sentry notifications about this bug. Unfortunately, we were "desensitized to the signal" because of #26966 as well as the testing team being spread pretty thin atm. If you have a different opinion on the best strategy, I will gladly defer to whatever diff you envision––just sharing how/why I approached this as I did. |
#26556 had a bug in that it did not properly determine the final dependency order of all IDs.
The bug was caused by this line, which @guswynn describes on Slack:
This means we just need to try again, but with the right approach to determining the final dependency order.
In addition, to do this, we need to allow the catalog to boot, initially, with out-of-order dependencies, which means reverting 7d348b6
I've tested this extensively locally but we'll be able to ensure it works using the cloud upgrade tests.
Motivation
This PR fixes a recognized bug.
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.