persist-cli: Add force_downgrade_since and force_downgrade_upper options to finalize shard
#27031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
force-pushed
the
persist-cli/force-finalize-shards
branch
from
44d6a15
to
c1d1e8b
Compare
bkirwi
approved these changes
May 16, 2024
| "opaque changed, expected: {expected_opaque:?}, actual: {actual_opaque:?}" | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd be kind of interested why it was easier to use the high-level interfaces for the writer and the low-level ones for the reader, but it's definitely not a problem!
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new options to the
persistcli admin finalizesubcommand,--force-downgrade-sinceand--force-downgrade-upper. This will allow us to forcibly finalize shards.I tested this manually by starting environmentd locally, creating a table, then CTRL+C the process and waiting for the leased readers to expire. I was then able to successfully tombstone the related shard.
Motivation
Cleanup unnecessary shards
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.